Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/router upgrade #197

Merged
merged 15 commits into from
Dec 21, 2017
Merged

Chore/router upgrade #197

merged 15 commits into from
Dec 21, 2017

Conversation

frickjack
Copy link
Contributor

@frickjack frickjack commented Nov 30, 2017 •
edited
Loading

Upgraded from router v2 to v4. API changed, so:

  • introduced 'ProtectedContent' container to manage access to pages that require auth - replaces withBoxAndNav, withAuthTimeout, and requireAuth wrappers
  • changed access to router-related properties in the code - new router has new and different props
  • also tacked on an optional cache to fetchJsonOrText to avoid repeatedly fetching read-only data like the dictionary and schema
  • introduce do-nothing Jenkinsfile - as place holder

resolve #165

@frickjack frickjack force-pushed the chore/router-upgrade branch from 9cb28e7 to a425799 Compare November 30, 2017 22:46
philloooo
philloooo reviewed Nov 30, 2017
View reviewed changes
src/Certificate/Quiz.jsx
@@ -1,14 +1,15 @@
import React, { Component } from 'react';
import { Form, FormError, RadioGroup, Radio } from 'react-form';
import { Form, RadioGroup, Radio } from 'react-form';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router-form v2 doesn't have FormError it seems ... :-(
https://react-form.js.org/#/
https://github.com/react-tools/react-form

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sad :/

@frickjack
refactor(router): bump to react-router v4
881c856 
still working on some failing tests
@frickjack
fix(router): fix UX bugs from new router
6d15604
@frickjack
fix(jest): fix tests broken by new router
2ac0d06
@frickjack
fix(Certificate): up react-form ver to fix errs
2153d28 
was getting stack-overflow warning in console -
bumped up to react-form v2 for Quiz component
@frickjack
fix(eslint): style conformance
da48dac
@frickjack
chore(Jenkinsfile): introduce NOOP Jenkinsfile
4637d45
@frickjack
fix(AuthTimeoutPopup): referencing undefined var
5f55fbe
@frickjack
fix(AuthPopup): mv auth popup to ProtectedContent
172c3cb 
so we don't get 'you must login' popups on pages
that don't require auth
@frickjack
fix(typos): bad var name, path match, codacy
030dbc6
@frickjack
fix(bgcolor): refactor for bgcolor
0f29097 
* make all pages children of ProtectedContent
* ProtectedContent introduces 'public' property
* ProtectedContent wraps children in Body with
   style property pass-through
* Fix couple jest tests after rebase
@frickjack frickjack force-pushed the chore/router-upgrade branch from 6d6950b to 0f29097 Compare December 5, 2017 21:54
thanh-nguyen-dang
thanh-nguyen-dang approved these changes Dec 21, 2017
View reviewed changes
Copy link
Contributor

@thanh-nguyen-dang thanh-nguyen-dang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@frickjack frickjack merged commit a9b4593 into master Dec 21, 2017
@zflamig zflamig deleted the chore/router-upgrade branch March 21, 2018 08:04
@pmartinov pmartinov mentioned this pull request Sep 21, 2023
Open
@urvi-occ urvi-occ mentioned this pull request Dec 19, 2023
Open
@pmartinov pmartinov mentioned this pull request Mar 26, 2024
Open
@pmartinov pmartinov mentioned this pull request Oct 14, 2024
Open
@urvi-occ urvi-occ mentioned this pull request Oct 17, 2024
Open
@pmartinov pmartinov mentioned this pull request Oct 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philloooo philloooo philloooo left review comments

@thanh-nguyen-dang thanh-nguyen-dang thanh-nguyen-dang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update to react-router v4
3 participants
@frickjack @philloooo @thanh-nguyen-dang